Update/automatically #22
Conversation
|
test failed because we haven't set user key and python token yet |
.circleci/config.yml
Outdated
| echo "Schama updated" | ||
| git add . | ||
| git commit -m 'update schema automatically' | ||
| git push -u origin |
There was a problem hiding this comment.
Shouldn't we specify the branch to push?
| 'reason': 'want'}, 'account_closure can get right result' | ||
| with pytest.raises(ValueError, match='Required parameters missing: reason'): | ||
| await api.account_closure({}) | ||
| assert (await api.exchange_rates({'exchange_rates': 1, 'base_currency': 'USD'})) == {'exchange_rates': 1, |
There was a problem hiding this comment.
is this updated automatically by some script?
There was a problem hiding this comment.
This is a test fixed manually by me.
| only: | ||
| - master | ||
| - master | ||
| - update_schema |
There was a problem hiding this comment.
Since the update_schema is run daily. Are we configuring the trigger via the UI ?
There was a problem hiding this comment.
we needn't trigger via UI, this cron configuration will trigger it
Please let me know if I misunderstand you or you have a deeper think.
There was a problem hiding this comment.
Previously since the trigger was missing i assumed you intended to add the trigger via the project settings rather than specifying the trigger in the yaml itself since as per the docs setting the trigger via the project settings seems to be the preferred approach. https://circleci.com/docs/migrate-scheduled-workflows-to-scheduled-pipelines/
chylli-deriv
force-pushed
the
update/automatically
branch
from
de11dd6 to
7ef1ea8
Compare
| command: | | ||
| git clone https://github.com/binary-com/deriv-developers-portal.git /tmp/deriv-developers-portal | ||
| curl -L https://cpanmin.us | perl - --sudo App::cpanminus | ||
| sudo cpanm -n Dir::Self File::Basename JSON::MaybeXS Log::Any Path::Tiny Template Syntax::Keyword::Try |
There was a problem hiding this comment.
Does it make sense to have a cpanfile for installing these dependencies ? Or is the dependencies too little to have a separate file for it ?
There was a problem hiding this comment.
This is a python project. I'm installing dependencies for that script scripts/regen-py.pl . I don't think its necessary to maintain a cpanfile.
.circleci/config.yml
Outdated
| branches: | ||
| only: | ||
| - master | ||
| - master |
| steps: | ||
| - checkout |
There was a problem hiding this comment.
the add_ssh_keys step is missing here. Do we need that to be able to push the updated schema to master ?
There was a problem hiding this comment.
I think we should use a user deploy key to push to master.
I'm not sure the token in that add_ssh_keys step in docs-build-deploy has permission to write origin master or not.
4 participants
No description provided.