Update Core/Route.php #75
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Slash at the End of the URL.
|
Thank you for the request - this is something that I will be including in an updated version of the framework, but for now I don't want to change it so that it's in line with the associated course. Thanks anyway |
|
Then you may close the request. I am looking forward to the new version. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added single line to check if the url ends with '/' or not. If it is not then line appends '/' at the end. In this way, there is no need to add 2 route with slashed and nonslashed one.
They both identical and one of them work for 'echo' and 'echo/' route.
$router->add('echo', ['controller' => 'Home', 'action' => 'echo']);$router->add('echo/', ['controller' => 'Home', 'action' => 'echo']);