Skip to content

Commit 050c2a1

Browse files
author
Priyanka Sangam
committed
merge 7.3 -> 7.4
2 parents b48ff7a + ef20181 commit 050c2a1

File tree

2 files changed

+14
-16
lines changed

2 files changed

+14
-16
lines changed

storage/ndb/src/kernel/blocks/dbdih/DbdihMain.cpp

+7-15
Original file line numberDiff line numberDiff line change
@@ -6620,21 +6620,13 @@ void Dbdih::removeNodeFromTable(Signal* signal,
66206620
*/
66216621
ndbrequire(tabPtr.p->tabLcpStatus == TabRecord::TLS_ACTIVE);
66226622

6623-
/**
6624-
* Save the table
6625-
* This can be skipped if the status is LCP_INIT_TABLES because
6626-
* no metadata updates have been done so far, therefore there
6627-
* are no changes which need to be reverted.
6628-
*/
6629-
if(c_lcpState.lcpStatus != LCP_INIT_TABLES)
6630-
{
6631-
tabPtr.p->tabCopyStatus = TabRecord::CS_REMOVE_NODE;
6632-
tabPtr.p->tabUpdateState = TabRecord::US_REMOVE_NODE;
6633-
tabPtr.p->tabRemoveNode = nodeId;
6634-
signal->theData[0] = DihContinueB::ZPACK_TABLE_INTO_PAGES;
6635-
signal->theData[1] = tabPtr.i;
6636-
sendSignal(reference(), GSN_CONTINUEB, signal, 2, JBB);
6637-
}
6623+
tabPtr.p->tabCopyStatus = TabRecord::CS_REMOVE_NODE;
6624+
tabPtr.p->tabUpdateState = TabRecord::US_REMOVE_NODE;
6625+
tabPtr.p->tabRemoveNode = nodeId;
6626+
signal->theData[0] = DihContinueB::ZPACK_TABLE_INTO_PAGES;
6627+
signal->theData[1] = tabPtr.i;
6628+
sendSignal(reference(), GSN_CONTINUEB, signal, 2, JBB);
6629+
66386630
if (noOfRemainingLcpReplicas == 0)
66396631
{
66406632
jam();

storage/ndb/test/ndbapi/testNodeRestart.cpp

+7-1
Original file line numberDiff line numberDiff line change
@@ -6296,7 +6296,13 @@ runBug18044717(NDBT_Context* ctx, NDBT_Step* step)
62966296
} while (0);
62976297
ndbout_c("restore original state of cluster and verify that there");
62986298
ndbout_c("is no core due to inconsistent c_lcpStatus/tabLcpStatus");
6299-
restarter.waitNodesStarted(&master, 1);
6299+
6300+
if (restarter.waitNodesStarted(&master, 1))
6301+
{
6302+
ndbout_c("master node failed to start");
6303+
return NDBT_FAILED;
6304+
}
6305+
63006306
if (restarter.insertErrorInAllNodes(0))
63016307
{
63026308
result = NDBT_FAILED;

0 commit comments

Comments
 (0)