Skip to content

Commit ef20181

Browse files
author
Priyanka Sangam
committed
merge 7.2 -> 7.3
2 parents 146c40f + 5c64417 commit ef20181

File tree

2 files changed

+14
-16
lines changed

2 files changed

+14
-16
lines changed

storage/ndb/src/kernel/blocks/dbdih/DbdihMain.cpp

+7-15
Original file line numberDiff line numberDiff line change
@@ -6547,21 +6547,13 @@ void Dbdih::removeNodeFromTable(Signal* signal,
65476547
*/
65486548
ndbrequire(tabPtr.p->tabLcpStatus == TabRecord::TLS_ACTIVE);
65496549

6550-
/**
6551-
* Save the table
6552-
* This can be skipped if the status is LCP_INIT_TABLES because
6553-
* no metadata updates have been done so far, therefore there
6554-
* are no changes which need to be reverted.
6555-
*/
6556-
if(c_lcpState.lcpStatus != LCP_INIT_TABLES)
6557-
{
6558-
tabPtr.p->tabCopyStatus = TabRecord::CS_REMOVE_NODE;
6559-
tabPtr.p->tabUpdateState = TabRecord::US_REMOVE_NODE;
6560-
tabPtr.p->tabRemoveNode = nodeId;
6561-
signal->theData[0] = DihContinueB::ZPACK_TABLE_INTO_PAGES;
6562-
signal->theData[1] = tabPtr.i;
6563-
sendSignal(reference(), GSN_CONTINUEB, signal, 2, JBB);
6564-
}
6550+
tabPtr.p->tabCopyStatus = TabRecord::CS_REMOVE_NODE;
6551+
tabPtr.p->tabUpdateState = TabRecord::US_REMOVE_NODE;
6552+
tabPtr.p->tabRemoveNode = nodeId;
6553+
signal->theData[0] = DihContinueB::ZPACK_TABLE_INTO_PAGES;
6554+
signal->theData[1] = tabPtr.i;
6555+
sendSignal(reference(), GSN_CONTINUEB, signal, 2, JBB);
6556+
65656557
if(noOfRemainingLcpReplicas == 0){
65666558
jam();
65676559
/**

storage/ndb/test/ndbapi/testNodeRestart.cpp

+7-1
Original file line numberDiff line numberDiff line change
@@ -6290,7 +6290,13 @@ runBug18044717(NDBT_Context* ctx, NDBT_Step* step)
62906290
} while (0);
62916291
ndbout_c("restore original state of cluster and verify that there");
62926292
ndbout_c("is no core due to inconsistent c_lcpStatus/tabLcpStatus");
6293-
restarter.waitNodesStarted(&master, 1);
6293+
6294+
if (restarter.waitNodesStarted(&master, 1))
6295+
{
6296+
ndbout_c("master node failed to start");
6297+
return NDBT_FAILED;
6298+
}
6299+
62946300
if (restarter.insertErrorInAllNodes(0))
62956301
{
62966302
result = NDBT_FAILED;

0 commit comments

Comments
 (0)