Specify input dtypes for the statistical functions #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions like mean() that perform divisions require floating-point inputs. All other functions require numeric inputs. This was mentioned in data-apis#232 but does not fix the main question of that issue (the behavior of the statistical functions on empty arrays). I can implement that as well if we come to an agreement about what it should say.
|
Not convinced that the input dtypes for mean, median, std, or variance should be restricted to only floating-point. The output dtype, as already specified for mean, std, variance is floating-point. Meaning, how libraries choose to cast/promote internally should be implementation-defined. |
|
Happy to change it to numeric. I was basing it off the elementwise functions, which only require floating-point input when the output type has to be floating-point. |
|
@asmeurer Yeah, that is true. In which case, having as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions like mean() that perform divisions require floating-point inputs.
All other functions require numeric inputs.
This was mentioned in #232 but does not fix the main question of that issue
(the behavior of the statistical functions on empty arrays). I can implement
that as well if we come to an agreement about what it should say.