Enable cookies for IP hostnames #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default aiohttp doesn't store cookies for urls with an IP address instead of a DNS name. There's some debate if this is the correct behavior based on reading of the spec, and for our use case (only ever contacting a single server endpoint) storing cookies for an IP based url shouldn't be any less secure. In certain deployments it may be more common to have dask-gateway running behind an IP address than with an explicit dns name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default aiohttp doesn't store cookies for urls with an IP address
instead of a DNS name. There's some debate if this is the correct
behavior based on reading of the spec, and for our use case (only ever
contacting a single server endpoint) storing cookies for an IP based url
shouldn't be any less secure. In certain deployments it may be more
common to have dask-gateway running behind an IP address than with an
explicit dns name.