Add worker dashboard #282
Merged
Add worker dashboard #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
commented
Jun 26, 2020
| @@ -576,6 +583,8 @@ async def start_worker( | |||
| scheduler_address=None, | |||
| local_directory="", | |||
| nanny=True, | |||
| dashboard=True, | |||
There was a problem hiding this comment.
The default of True here matches the dask-worker CLI default. It differs from the distributed.Worker default of False. I think following the CLI default is appropriate.
xref dask#280 (comment) test-kubernetes
|
I'm not sure why, but my latest commits aren't showing up here. |
|
github is having issues right now :/ |
TomAugspurger
force-pushed
the
worker-dashboard
branch
from
4c9a172 to
a3db060
Compare
|
@jcrist all green. Did you have any thoughts on the need for tests here? |
jcrist
approved these changes
Jul 15, 2020
|
Fine by me. I'm hoping to remove the need for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #280 (comment)
I'm unsure about tests for this...