Migrate to null safety and update to latest dependencies #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sortie
approved these changes
Oct 28, 2021
| @@ -22,33 +32,24 @@ void main(List<String> args) async { | |||
| print( | |||
| "Usage: update_homebrew.dart -r version -c channel [-k ssh_key] [-n]\n" | |||
| " ssh_key should allow pushes to $githubRepo on github"); | |||
| exitCode = 1; | |||
| exitCode = 64; | |||
There was a problem hiding this comment.
Why do you need to discern this from the above exit? Are you trying to handle one of them? The above one seems the most interesting case to catch, maybe it should be the 64 one?
There was a problem hiding this comment.
https://pub.dev/documentation/io/latest/io/ExitCode/usage-constant.html
Seemed like an appropriate value for this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--dry-runto not touch the checkout.bin/update_homebrew.dart(dry run doesn't throw)./cc @kevmoo