Make delay of preview animation configurable #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as just way too fast) also removed (seemingly necessary) call to getWorkingAnimation()
Owner
|
Looks great! Thanks. I'll move the spinner this week when I get a spare minute. |
|
would be great to get this pr accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the current animation preview is way too fast (30ms per frame), I've added a spinner into the animation preview panel.
It lets the user configure the delay in milliseconds (defaults to 500) for each frame/delay.
I've got no experience with jswing positioning so the position isn't in the same row as the play/pause button. If it isn't too much trouble, can you adjust it after a merge?