Skip to content

Some MD files are encoded as UTF-8-BOM and are ignored by Jekyll #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mamintoosi opened this issue Feb 2, 2024 · 1 comment
Closed

Comments

@mamintoosi
Copy link

Dear Richard, thank you, for creating this wonderful course on modern C++. I have learned a lot from it and I appreciate your generosity in sharing it with the world. I have forked your repository, and I am modifying it to suit my own needs and preferences. I have also created a GitHub Pages website for it using the Jekyll site generator and the just-the-docs template. You can check it out here: https://fum-cs.github.io/modern-cpp/.

I encountered a problem where some of the markdown files (01 - 04) were not rendered by Jekyll. I discovered that it was because these files were encoded as UTF-8-BOM, which Jekyll ignored. I converted the encoding of these files to UTF-8 using Notepad++, and the problem was fixed.

cpp-tutor added a commit that referenced this issue Feb 2, 2024
@cpp-tutor
Copy link
Owner

Thanks for the report, I've now removed the BOM from the affected files you describe (also 08). Checking out your site, it looks very nice! If you do make substantial corrections/additions, feel free to submit a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants