Skip to content

AppSwitch does not provide any keyboard accessibility #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roastery-zz opened this issue Oct 20, 2018 · 0 comments · Fixed by #84
Closed

AppSwitch does not provide any keyboard accessibility #44

roastery-zz opened this issue Oct 20, 2018 · 0 comments · Fixed by #84

Comments

@roastery-zz
Copy link

This code does not work as expected:

<AppSwitch tabIndex="0" variant="pill" color="primary"
  checked={isChecked} onChange={this.handleChange}/>

Actual result:

  • tabIndex is rendered on the <input> which has display: none.
  • This does not work in any browser I've tested, the control is skipped entirely in the tab order.

Desired result:

  • tabIndex should be rendered on the wrapped <label>.
  • Keyboard support per ARIA checkbox guidelines should be implemented (pressing Space or Enter should toggle the switch)
xidedix added a commit that referenced this issue Aug 1, 2019
- fix(Switch): checked props and state out of sync - thanks @gravitymedianet @jinixx
- fix(Switch): does not provide any keyboard accessibility - thanks @roastery-zz close #44
@xidedix xidedix mentioned this issue Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant