Skip to content

Conversation

htnminh
Copy link

@htnminh htnminh commented Sep 11, 2025

fix(template/filebrowser): correct healthcheck for Filebrowser

Changes

  • remove healthcheck in compose

Issues

  • healthcheck is already defined in the image, keeping healthcheck command as-is in compose broke since wget should be used instead of curl

@djsisson
Copy link
Contributor

was this done by ai?

127.0.0.1 is localhost

this image has a builtin healthcheck, it has a script at /healthcheck.sh which checks the correct env for where to run wget

so it is safe to remove from the compose file, and use the builtin healthcheck

@Cinzya Cinzya added the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Sep 11, 2025
@htnminh htnminh changed the title fix(template/filebrowser): correct routing and healthcheck for Filebrowser fix(template/filebrowser): correct healthcheck for Filebrowser Sep 11, 2025
@htnminh
Copy link
Author

htnminh commented Sep 11, 2025

was this done by ai?

127.0.0.1 is localhost

this image has a builtin healthcheck, it has a script at /healthcheck.sh which checks the correct env for where to run wget

so it is safe to remove from the compose file, and use the builtin healthcheck

i see. i have updated to use the builtin healthcheck bash file.

@djsisson
Copy link
Contributor

its already defined in the image, no need to redefine it

image

@htnminh
Copy link
Author

htnminh commented Sep 11, 2025

i think it's good now lol, sorry i'm quite new here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Service Issues requesting or PRs adding/fixing service templates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants