-
Notifications
You must be signed in to change notification settings - Fork 814
adding YAML support #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
adding YAML support #748
Conversation
Was also looking for a similar feature, but will likely just write an updater for standard-version to invoke. What about the chart property Maybe you could specify the property path to update instead of assuming it'll always be {
"filename": "a/deep/package/dot/yaml/file/MY_VERSION_TRACKER.yaml",
"type": "yaml",
"propertyPath": "version"
},
{
"filename": "a/deep/package/dot/yaml/file/MY_VERSION_TRACKER.yaml",
"type": "yaml",
"propertyPath": "appVersion"
}, It does make me wonder though, whether this would need to handle when there's a prerelease like "2.0.0-alpha"... does # This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.0
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "1.0.0" |
Hi, that could be a good idea But I would LOVE that this PR (and this one ! #591) to be merge before adding But it seems that this repo is dead ? Lots of issues/questions without any response, PR not followed (the java one is more than one year) Waiting for this to be merge, you can use my fork as it includes yaml and java support |
} | ||
|
||
module.exports.writeVersion = function (contents, version) { | ||
const yaml = YAML.parse(contents) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const yaml = YAML.parseDocument(contents);
yaml.set('version', version);
return yaml.toString();
would be better as it would preserve the original comments, formatting etc.
6046fc5
to
69d722f
Compare
Hi,
As we working with some Helm charts, and using conventional commits, we also think that it could be a good idea to use standard-version on them but YAML support does not exist.
As Chart.yaml got a
version
key we decided to bring you this PR to support YAML file as general, assuming they have aversion
key like JSON updater