implement new CI with Github Actions #65
Conversation
Signed-off-by: Mateus Felipe C. C. Pinto <mateusfccp@gmail.com>
Signed-off-by: Mateus Felipe C. C. Pinto <mateusfccp@gmail.com>
Signed-off-by: Mateus Felipe C. C. Pinto <mateusfccp@gmail.com>
|
We can just delete master and rename develop. The history of master commits it's pretty shit ones. Thanks! ASAP I will review this. Please @luksamuk take a look too if you can. |
There was a problem hiding this comment.
Pretty good approach. Thanks for contributing, @mateusfccp
I've requested just a few changes and other questions. Please take a look.
.github/workflows/deployment.yaml
Outdated
| shell: bash | ||
| run: | | ||
| mkdir static | ||
| find . "(" -name "*.html" -o -name "*.css" -o -name "*.js" ")" -not -path "./static/*" -not -path "./.github/*" -exec cp {} static \; |
There was a problem hiding this comment.
That's a pretty long command. Can we simplify somehow?
There was a problem hiding this comment.
Maybe we can put this logic into make too, make deploy-static. I really don't like putting too much complexity on CI/CD files.
Another reason: if we want to serve the site locally, we will need to do this, right?
Since we renamed the paths from long.setup and short.setup.
There was a problem hiding this comment.
I actually didn't think of and didn't test serving it locally.
Good catch!
If we don't care for |
Signed-off-by: Mateus Felipe C. C. Pinto <mateusfccp@gmail.com>
Rename done. Deleted master, then renamed develop -> master. |
2 participants
I tested it in this separate branch and it seemed to work. The lastest deployed Github Pages has been done with this configuration (refer to https://github.com/commonlispbr/commonlispbr.github.io/actions/runs/8769442418)
After merging this, we are going to have to overwrite master with develop.
Solves #49