Reescreve a página de regras #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryukinix
requested changes
Sep 20, 2020
There was a problem hiding this comment.
Parabéns pela iniciativa, @luksamuk! A gente deveria ter feito isso já tem um tempo, fico contente que finalmente estamos atualizando as regras.
Como conversei com você anteriormente, acredito que seja importante pensar na coesão das regras como fator essencial. Então acredito que seria interessante se conseguirmos reduzir as 7 regras para 5. A regra 4 por exemplo acredito que possa ser condensada em 1.
Deixei algumas sugestões na revisão de texto e discuti outros pontos que apareceram quando comecei a ler.
Co-authored-by: Manoel Vilela <manoel_vilela@engineer.com>
Co-authored-by: Manoel Vilela <manoel_vilela@engineer.com>
Co-authored-by: Manoel Vilela <manoel_vilela@engineer.com>
Co-authored-by: Manoel Vilela <manoel_vilela@engineer.com>
|
Vou fazer mais algumas alterações com base no review até agora do @ryukinix. |
jpellegrini
reviewed
Sep 20, 2020
jpellegrini
reviewed
Sep 20, 2020
renanroberto
previously approved these changes
Sep 20, 2020
jpellegrini
reviewed
Sep 20, 2020
parjanya
reviewed
Sep 20, 2020
|
Uma sugestão pra quem for dar merge: escolha a opção de squash. |
ryukinix
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💣