refactor(Commit): refactor _prompt_commit_questions and fix some type… #1632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearomorphism
requested review from
Lee-W,
noirbizarre and
woile
as code owners
bearomorphism
force-pushed
the
refactor-prompt
branch
from
5fa3486 to
5af9f3f
Compare
bearomorphism
commented
Sep 28, 2025
| if len(subject) > limit: | ||
| raise CommitMessageLengthExceededError( | ||
| f"Length of commit message exceeds limit ({message_len}/{message_length_limit})" | ||
| f"Length of commit message exceeds limit ({len(subject)}/{limit}), subject: '{subject}'" |
There was a problem hiding this comment.
I believe appending more details is not a breaking change?
bearomorphism
commented
Sep 28, 2025
| return message | ||
|
|
||
| def _validate_subject_length(self, message: str) -> None: | ||
| # By the contract, message_length_limit is set to 0 for no limit |
There was a problem hiding this comment.
Not sure if it still works if we use None for no limit
There was a problem hiding this comment.
Related to a comment in #1574
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-9-2 #1632 +/- ##
=========================================
Coverage ? 98.32%
=========================================
Files ? 58
Lines ? 2685
Branches ? 0
=========================================
Hits ? 2640
Misses ? 45
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
force-pushed
the
refactor-prompt
branch
from
5af9f3f to
6f9fd0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… hint
Description
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context