Skip to content

refactor(Init): remove the variable values_to_add and the _update_config_file function for readability #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: v4-9-0-test
Choose a base branch
from
Open

refactor(Init): remove the variable values_to_add and the _update_config_file function for readability #1537

wants to merge 2 commits into from

Conversation

bearomorphism
Copy link
Contributor

@bearomorphism bearomorphism commented Jun 11, 2025 •
edited
Loading

Description

Checklist

@bearomorphism bearomorphism changed the base branch from master to v4-9-0-test June 11, 2025 07:45
@Lee-W Lee-W added this to the 4.9.0 milestone Jun 11, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v4-9-0-test@6b4f8b0). Learn more about missing BASE report.

Additional details and impacted files 
@@              Coverage Diff               @@
##             v4-9-0-test    #1537   +/-   ##
==============================================
  Coverage               ?   97.99%           
==============================================
  Files                  ?       58           
  Lines                  ?     2697           
  Branches               ?        0           
==============================================
  Hits                   ?     2643           
  Misses                 ?       54           
  Partials               ?        0
Flag Coverage Δ
unittests 97.99% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism bearomorphism force-pushed the r-init-values-to-add branch from 7da709d to dfc17bd Compare June 11, 2025 07:47
@bearomorphism bearomorphism marked this pull request as draft June 11, 2025 07:50
@bearomorphism bearomorphism marked this pull request as ready for review June 11, 2025 07:56
@bearomorphism bearomorphism changed the title refactor(Init): remove the variable values_to_add and the update_config function for readability refactor(Init): remove the variable values_to_add and the _update_config_file function for readability Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woile woile Awaiting requested review from woile woile is a code owner

@Lee-W Lee-W Awaiting requested review from Lee-W Lee-W is a code owner

@noirbizarre noirbizarre Awaiting requested review from noirbizarre noirbizarre is a code owner

Assignees
No one assigned
Labels
pr-status: wait-for-review type: refactor
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bearomorphism @Lee-W