Skip to content

Conversation

@marcobiscaro2112
Copy link
Collaborator

@marcobiscaro2112 marcobiscaro2112 commented Jul 8, 2025

Support running aws-api in babashka. Ignoring whitespaces during review is recommended.

  • Conditional reader around JSON fns to support babashka (latest version of data.json doesn't work in babashka anymore)
  • deftype -> reify (deftype implementing a Java interface is not supported by babashaka)
  • Improve resource loading (ensure Clojure's class loader is used; workaround babashka bug)
  • Run tests in babashka as well

This ensures `cognitect_aws_http.edn` is always loaded with the expected class loader (instead of depending on the context of the thread that is trying to load it).
deftype implementing a Java interface is not supported by babashaka. Use reify instead, which is supported.

Note that the object returned by reify already implements IObj, so there is no need to manually track metadata.
Support early access versions as well (e.g. `25-ea`).
@marcobiscaro2112 marcobiscaro2112 marked this pull request as ready for review July 29, 2025 18:43
Copy link
Collaborator

@scottbale scottbale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@marcobiscaro2112 marcobiscaro2112 force-pushed the SLT-22/babashka-support branch from cb53233 to 9a1d307 Compare August 4, 2025 18:15
Copy link
Collaborator

@scottbale scottbale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks even better now!

@marcobiscaro2112 marcobiscaro2112 merged commit 3a80f2f into main Aug 5, 2025
4 checks passed
@marcobiscaro2112 marcobiscaro2112 deleted the SLT-22/babashka-support branch August 5, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants