Fix macOS application icon display #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Regenerate corrupted icon.icns file (8 bytes → 840KB with proper multi-resolution support) - Fix rimraf API compatibility in clean-dev-assets.js for Node.js module changes - Add missing make build-mac command to development documentation The main issue was a corrupted icon.icns file that caused blank icons on macOS. Regenerated using iconutil with proper iconset structure containing resolutions from 16x16 to 1024x1024 pixels for full macOS system compatibility.
|
Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was a corrupted icon.icns file that caused blank icons on macOS. Regenerated using iconutil with proper iconset structure containing resolutions from 16x16 to 1024x1024 pixels for full macOS system compatibility.
make build-macfor the icon fix to be available in downloadable DMG files on GitHub releases.