Fixed some issues in relation to http headers, profile links and proxies #220

sammychinedu2ky · 2020-09-08T08:09:40Z

Added links to the profile sections of teams in the https://www.codeuino.org/#/team
Fixed issue in the netlify functions. The callback keyword wasn't needed since the async keyword was used and this made it return Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
So I resolved these issues

netlify · 2020-09-08T08:09:46Z

Deploy preview for codeuino processing.

Building with commit 4f68ea2

https://app.netlify.com/sites/codeuino/deploys/5f5c875817de2b00070645ce

sammychinedu2ky · 2020-09-08T17:01:56Z

I changed various props name to standard version which removes most errors during development. For instance, changed tabindex to TabIndex and class to className.
I edited the package.json file to use the lambda server after building the site locally (npm run build and npm run start). This ensures that you get to test the local version of netlify function after building your site.
I also set a proxy that points "localhost:9000" to "/.netlify/functions" this ensures that the netlify preview renders properly with the tweets in the preview mode.
here is the preview link generated https://deploy-preview-220--codeuino.netlify.app/#/

sammychinedu2ky

made comments to the areas where I made changes

sammychinedu2ky · 2020-09-09T06:46:29Z

netlify-functions/getBlogs.js

@@ -1,14 +1,14 @@
 const axios = require("axios");
 const xml2js = require("xml2js");

-exports.handler = async (event, context, callback) => {


The callback wasn't needed since the async keyword was used. This helps prevent some errors

sammychinedu2ky · 2020-09-09T06:47:09Z

netlify-functions/getBlogs.js

  const mediumURL = "https://medium.com/feed/codeuino";
  try {
    const response = await axios.get(`${mediumURL}`);
    const data = response.data;
    xml2js.parseString(data, (err, result) => {
      const sendthis = result.rss.channel[0].item.slice(0, 3);
-      callback(null, {


had to use the return keyword because the async keyword was used to instantiate the function

sammychinedu2ky · 2020-09-09T06:49:11Z

package.json

@@ -53,7 +54,7 @@
  "scripts": {
    "lambda-serve": "netlify-lambda serve netlify-functions",
    "heroku-postbuild": "npm run build",
-    "start": "serve -s build -l 3000",


needed to also run the lambda function to ensure communication to serverless function is possible

sammychinedu2ky · 2020-09-09T06:51:50Z

src/helpers/apiBase.js

@@ -1,3 +1,2 @@
-export default process.env.NODE_ENV === "development"


had to use "/.netlify/functions" because a proxy file was created

sammychinedu2ky · 2020-09-09T06:54:00Z

src/pages/Team/BoardMembers.js

-    linkedin: ""
+    linkedin: "https://www.linkedin.com/in/jaskiratsingh2000/"
  },
  {
    name: "Devesh",
    post: "Donut Maintainer",
    headline:
      "foss contributor|board member@CODEUINO|software engineer@SHAW ACADEMY|ex-intern@SHAW ACADEMY|HASURA| INTERNSHALA|HIREINK|INDICIUMHUB|",
    profile: devesh,
-    github: "",
-    linkedin: ""
+    github: "https://github.com/devesh-verma",
+    linkedin: "https://www.linkedin.com/in/devesh-verma/"
  },
  {
    name: "Vaibhav D. Aren",
    post: "Board Member",
    headline:
      "SDE at HashedIn | GSOC 2018 Developer @SugarLabs | GSOC-19 Mentor @JBOSS(Codeuino)| GCI -18 Mentor @SugarLabs .",
    profile: vaibhav,
-    github: "",
-    linkedin: ""
+    github: "https://github.com/vaibhavdaren",
+    linkedin: "https://www.linkedin.com/in/vaibhavdaren/"
  },
  {
    name: "Ayush Nagar",
    post: "CodeBadge Maintainer",
    headline: "Student Mentor at Google Code-in",
    profile: "https://avatars1.githubusercontent.com/u/32647423?s=460&v=4",
    github: "https://github.com/ayushnagar123",
-    linkedin: ""
+    linkedin: "https://www.linkedin.com/in/ayushnagar123/"
  },
  {
    name: "Siddharth",
    post: "Designer",
    headline: "Student Mentor at Google Code-in",
    profile: "https://avatars1.githubusercontent.com/u/33068322?s=460&v=4",
-    github: "",
-    linkedin: ""


added profile links for GitHub and LinkedIn

vaibhavdaren · 2020-09-12T05:35:21Z

@sammychinedu2ky can you resolve these conflicts

….codeuino.org into development

sammychinedu2ky · 2020-09-12T08:45:48Z

src/setupProxy.js

+const {createProxyMiddleware} = require('http-proxy-middleware')
+// this proxy code allows the use of .netlify/function in both development and production
+module.exports = function(app){
+    app.use(
+        createProxyMiddleware(
+        "/.netlify/functions", {
+          target: "http://localhost:9000",
+          pathRewrite: {
+            '^/\\.netlify/functions': ''
+          }
+        }
+        )
+    )


Proxy file to redirect all request from /.netlify/functions to http://localhost:9000 .
This ensures that netlify function works in both build state of local project and the preview mode of netlify during a pull request

accepted change change to package.json set the key prop properly centered headers added key prop proxy:localdev

sammychinedu2ky added 3 commits September 8, 2020 08:26

fix:profile links added

84c4fd9

fix: added profile links

8ab2b46

fix: http headers issue

1d777fe

sammychinedu2ky added 8 commits September 8, 2020 17:42

proxy module

98921ea

proxy module added

3123549

using .netlify/function as base

4f003e0

added proxy file

b1b31a9

chaned base link

c100690

added proxy

4ba61b9

changed the start script

2ceec03

removed header line

235766f

sammychinedu2ky changed the title ~~Fixed some issues in relation to http headers and profile links~~ Fixed some issues in relation to http headers, profile links and proxies Sep 9, 2020

sammychinedu2ky commented Sep 9, 2020

View reviewed changes

sammychinedu2ky added 7 commits September 12, 2020 07:24

Merge branch 'development' of https://github.com/codeuino/website-www…

76b0688

….codeuino.org into development

accepted change

9c71bb8

change to package.json

6f5e8a6

set the key prop properly

c58fd6e

centered headers

b9a74ab

added key prop

88a4bb4

proxy:localdev

4f68ea2

sammychinedu2ky commented Sep 12, 2020

View reviewed changes

vaibhavdaren approved these changes Sep 12, 2020

View reviewed changes

vaibhavdaren merged commit 84fa2fe into codeuino:development Sep 12, 2020

ksraj123 pushed a commit to ksraj123/website-www.codeuino.org that referenced this pull request Sep 25, 2020

PR codeuino#220

43a5d7c

accepted change change to package.json set the key prop properly centered headers added key prop proxy:localdev

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed some issues in relation to http headers, profile links and proxies #220

Fixed some issues in relation to http headers, profile links and proxies #220

Uh oh!

sammychinedu2ky commented Sep 8, 2020

Uh oh!

netlify bot commented Sep 8, 2020 •

edited

Loading

Uh oh!

sammychinedu2ky commented Sep 8, 2020 •

edited

Loading

Uh oh!

sammychinedu2ky left a comment

Uh oh!

sammychinedu2ky Sep 9, 2020 •

edited

Loading

Uh oh!

sammychinedu2ky Sep 9, 2020

Uh oh!

sammychinedu2ky Sep 9, 2020

Uh oh!

sammychinedu2ky Sep 9, 2020

Uh oh!

sammychinedu2ky Sep 9, 2020

Uh oh!

vaibhavdaren commented Sep 12, 2020

Uh oh!

sammychinedu2ky Sep 12, 2020

Uh oh!

Uh oh!

		@@ -1,3 +1,2 @@
		export default process.env.NODE_ENV === "development"

Fixed some issues in relation to http headers, profile links and proxies #220

Fixed some issues in relation to http headers, profile links and proxies #220

Uh oh!

Conversation

sammychinedu2ky commented Sep 8, 2020

Uh oh!

netlify bot commented Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sammychinedu2ky commented Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sammychinedu2ky left a comment

Choose a reason for hiding this comment

Uh oh!

sammychinedu2ky Sep 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sammychinedu2ky Sep 9, 2020

Choose a reason for hiding this comment

Uh oh!

sammychinedu2ky Sep 9, 2020

Choose a reason for hiding this comment

Uh oh!

sammychinedu2ky Sep 9, 2020

Choose a reason for hiding this comment

Uh oh!

sammychinedu2ky Sep 9, 2020

Choose a reason for hiding this comment

Uh oh!

vaibhavdaren commented Sep 12, 2020

Uh oh!

sammychinedu2ky Sep 12, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

netlify bot commented Sep 8, 2020 •

edited

Loading

sammychinedu2ky commented Sep 8, 2020 •

edited

Loading

sammychinedu2ky Sep 9, 2020 •

edited

Loading