-
Notifications
You must be signed in to change notification settings - Fork 2.4k
🔨 Cleanup components package #4861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Cleanup components package #4861
Conversation
This reverts commit 32b350f
Hey I was the one that reverted those things because we need a lot of testing before updating dependencies |
@SaraVieira That's why we have the visual tests, no? 🤔 I only updated minor versions, so no breaking changes too |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3e15e87:
|
Build for latest commit 3e15e87 is at https://pr4861.build.csb.dev/s/new. |
@SaraVieira I only updated minor versions, so no breaking changes too. Updated to latest minor without breaking changes:
Deleted since they're not used:
Added because they weren't in the (dev)dependency list:
|
Thanks for helping us clean up! Due to the time we spend reviewing and testing PRs we are forced to evaluate cost/benefit of all well intended contributions. This PR does not seem to improve user or developer experience in a noticeable way. We are very sorry that you spent time on this, only to see us closing the PR. But we hope you understand our reasoning and do not feel discouraged to make other contributions 😄 |
Follow-up of #4506
When merging
master
into #4506, some things went missing/wrong (especially inpackage.json
).So I reverted that PR and cherry-picked all the commits afterwards.
This PR is the result of how #4506 should have been.