Skip to content

Conversation

MichaelDeBoey
Copy link
Contributor

Follow-up of #4506

When merging master into #4506, some things went missing/wrong (especially in package.json).
So I reverted that PR and cherry-picked all the commits afterwards.

This PR is the result of how #4506 should have been.

@SaraVieira
Copy link
Contributor

Hey

I was the one that reverted those things because we need a lot of testing before updating dependencies

@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Sep 8, 2020

@SaraVieira That's why we have the visual tests, no? 🤔

I only updated minor versions, so no breaking changes too

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3e15e87:

Sandbox Source
Notifications Test Configuration

@lbogdan
Copy link
Contributor

lbogdan commented Sep 8, 2020

Build for latest commit 3e15e87 is at https://pr4861.build.csb.dev/s/new.

@MichaelDeBoey
Copy link
Contributor Author

@SaraVieira I only updated minor versions, so no breaking changes too.
I also deleted some packages that weren't used anywhere in the @codesandbox/components packages and added some packages that weren't in the (dev)dependency list.

Updated to latest minor without breaking changes:

  • @reach/auto-id
  • @reach/menu-button
  • @reach/skip-nav
  • @reach/tooltip
  • @reach/visually-hidden
  • chromatic
  • @storybook/*
  • @types/styled-components
  • rimraf
  • simple-git

Deleted since they're not used:

  • codesandbox-api
  • date-fns
  • typeface-inter
  • @storybook/csf
  • @types/lodash
  • cpx
  • np
  • postinstall-postinstall

Added because they weren't in the (dev)dependency list:

  • react-is
  • @types/dot-object
  • @types/react-tagsinput
  • execa
  • react
  • react-dom

@christianalfoni
Copy link
Contributor

christianalfoni commented Sep 9, 2020

Thanks for helping us clean up!

Due to the time we spend reviewing and testing PRs we are forced to evaluate cost/benefit of all well intended contributions. This PR does not seem to improve user or developer experience in a noticeable way. We are very sorry that you spent time on this, only to see us closing the PR. But we hope you understand our reasoning and do not feel discouraged to make other contributions 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants