Skip to content

Embed throws errors to console when editing or switching views #226

@malwilley

Description

@malwilley

This can be seen on the homepage or any direct link to an embed, this one for example. While editing or switching views, it throws errors to the console:

image

I poked around a bit and found that the CodeEditor component isn't being called with all the necessary props. Adding corrections={[]} seems to be enough to fix it (I assume corrections is not used for embed?). It is also missing a couple other required props but those don't result in any bugs. Running the flow typechecker gives nearly 900 errors 😬

Would you accept a PR to fix this issue? And perhaps some other typing errors?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions