Skip to content

Fix/continue #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 1, 2019
Merged

Fix/continue #63

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0fd10d3
remove unused
ShMcK Dec 1, 2019
bdf0c32
cleanup todos
ShMcK Dec 1, 2019
6eddbb7
fix currentStepId on continue load
ShMcK Dec 1, 2019
eb3628e
remove position logs
ShMcK Dec 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove position logs
  • Loading branch information
@ShMcK
ShMcK committed Dec 1, 2019
commit eb3628e50c5d3101e5fef1f219bb8e55ef3486ee
9 changes: 0 additions & 9 deletions src/channel/state/Position.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,23 +13,16 @@ class Position {
this.value = defaultValue
}
public get = () => {
if (!this.value.levelId || !this.value.stepId) {
console.log('NO POSITION RETURNED')
}
console.log(this.value)
return this.value
}
public set = (value: CR.Position) => {
console.log('--- position set')
console.log(value)
this.value = value
}
public reset = () => {
this.value = defaultValue
}
// calculate the current position based on the saved progress
public setPositionFromProgress = (tutorial: G.Tutorial, progress: CR.Progress): CR.Position => {
console.log('--- set position from progress')
// tutorial already completed
// TODO handle start again?
if (progress.complete) {
Expand Down Expand Up @@ -64,8 +57,6 @@ class Position {
stepId: currentStep.id,
}

console.log('--- calculated set position from progress')
console.log(this.value)
return this.value
}
}
Expand Down