Skip to content

Feature/show command running #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 18, 2019
Merged

Feature/show command running #58

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
12962fa
update linter
ShMcK Nov 17, 2019
121d5cb
create indeterminate loading checkbox
ShMcK Nov 17, 2019
3888e8b
add relative positioning to pages for storybook
ShMcK Nov 17, 2019
d0b8ee6
setup processes component
ShMcK Nov 17, 2019
70119ed
refactor level & step file structure
ShMcK Nov 17, 2019
0ee8b05
style without absolute positioning
ShMcK Nov 17, 2019
5133dad
fix level index
ShMcK Nov 17, 2019
3599137
setup tutorial level process events viewer
ShMcK Nov 17, 2019
aa978af
define processes
ShMcK Nov 17, 2019
6113648
setup command actions
ShMcK Nov 17, 2019
9999668
setup git actions to send command feedback
ShMcK Nov 17, 2019
7f8789c
fix typo bug
ShMcK Nov 18, 2019
b35f6b1
update debugger
ShMcK Nov 18, 2019
8e8fa50
working command tracker
ShMcK Nov 18, 2019
b148fa5
fix ui issue
ShMcK Nov 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix level index
  • Loading branch information
@ShMcK
ShMcK committed Nov 17, 2019
commit 5133dadf3088edc1e55ee4f94e12e4aacb25d3f9
3 changes: 2 additions & 1 deletion web-app/src/containers/Tutorial/LevelPage/Level.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ const Level = ({ level, onContinue, onLoadSolution }: Props) => {
<div>
<div style={styles.footer}>
<span>
{level.index ? `${level.index.toString()}.` : ''} {level.title}
{typeof level.index === 'number' ? `${level.index + 1}. ` : ''}
{level.title}
</span>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions web-app/stories/Level.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ storiesOf('Level', module)
.add('Level', () => {
const level = {
id: 'L1',
index: 2,
index: 0,
title: 'A Title',
description: 'A summary of the level',
content: 'Some content here in markdown',
Expand Down Expand Up @@ -77,6 +77,7 @@ storiesOf('Level', module)
.add('Level 2', () => {
const level = {
id: 'L1',
index: 1,
title: 'A Title',
description: 'A description',
content: 'Should support markdown test\n ```js\nvar a = 1\n```\nwhew it works!',
Expand Down Expand Up @@ -115,7 +116,6 @@ storiesOf('Level', module)
status: 'INCOMPLETE',
},
],
index: 0,
status: 'ACTIVE',
}
return <Level level={level} onContinue={action('onContinue')} onLoadSolution={action('onLoadSolution')} />
Expand Down