Skip to content

Fix/check git remote #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 11, 2020
Merged

Fix/check git remote #236

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d7a5e42
checkRemoteConnects
ShMcK Apr 10, 2020
98932e0
add git remote check
ShMcK Apr 10, 2020
13292c8
run remote check after init
ShMcK Apr 10, 2020
a71d857
respond with Tutorial configure error
ShMcK Apr 10, 2020
9fdb5df
setup better tutorial config errors
ShMcK Apr 10, 2020
345770f
load error markdown in middleware
ShMcK Apr 10, 2020
2b73484
standardize error messages
ShMcK Apr 11, 2020
99b8604
clear errors on success
ShMcK Apr 11, 2020
3bbf2be
fix git not installed error
ShMcK Apr 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix git not installed error 
Signed-off-by: shmck <shawn.j.mckay@gmail.com>
  • Loading branch information
@ShMcK
ShMcK committed Apr 11, 2020
commit 3bbf2be42b129b83d3ec6f6a8a7399b7a65f6660
14 changes: 12 additions & 2 deletions src/channel/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,13 +146,22 @@ class Channel implements Channel {
// Should wait for workspace before running otherwise requires access to root folder
const isGitInstalled = await gitVersion()
if (!isGitInstalled) {
this.send({ type: 'GIT_NOT_INSTALLED' })
const error: E.ErrorMessage = {
type: 'GitNotFound',
message: '',
actions: [
{
label: 'Check Again',
transition: 'RETRY',
},
],
}
this.send({ type: 'VALIDATE_SETUP_FAILED', payload: { error } })
return
}
this.send({ type: 'SETUP_VALIDATED' })
return
case 'EDITOR_REQUEST_WORKSPACE':
console.log('request workspace')
openWorkspace()
return
// load step actions (git commits, commands, open files)
Expand Down Expand Up @@ -183,6 +192,7 @@ class Channel implements Channel {
// onError(new Error(`Error Markdown file not found for ${action.type}`))
})

// log error to console for safe keeping
console.log(`ERROR:\n ${errorMarkdown}`)

if (errorMarkdown) {
Expand Down