Skip to content

VSCode 1.39.2 support #264

@AdamZaczek

Description

@AdamZaczek
Contributor

Is your feature request related to a problem? Please describe.
We'd love to support coderoad inside strove.io by default. We use vscode 1.39.2 for now. Could we have support for this version? I'm almost 100% sure API will be compatible.

Describe the solution you'd like
Add
"engines": {
"vscode": "^1.39.2"
},

And
under "dependencies" key
"@types/vscode": "^1.39.2",

To package.json

Additional context
So far, users using strove are unable to access coderoad and we're not ready to bumb vscode version just yet.

Activity

ShMcK

ShMcK commented on Apr 14, 2020

@ShMcK
Member

@AdamZacrek great to hear!

Let me install version 1.39.2 of VSCode and test locally later today. If it's successful, we can publish it under that version.

There is potential something may break.

ShMcK

ShMcK commented on Apr 15, 2020

@ShMcK
Member

@AdamZaczek I've released a version that runs on VSCode v1.39.2.
It should be available in the store soon as v0.2.4.

Luckily no breaking changes!

AdamZaczek

AdamZaczek commented on Apr 15, 2020

@AdamZaczek
ContributorAuthor

Awesome, we're adding it Strove by default!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @ShMcK@AdamZaczek

    Issue actions

      VSCode 1.39.2 support · Issue #264 · coderoad/coderoad-vscode