Skip to content

Draft: Feature/more rules #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Draft: Feature/more rules #54

wants to merge 5 commits into from

Conversation

EranNL
Copy link
Contributor

@EranNL EranNL commented Feb 10, 2021

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@EranNL EranNL changed the title Feature/more rules Draft: Feature/more rules Feb 10, 2021
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #54 (72c5221) into develop (fe9a5a1) will decrease coverage by 1.79%.
The diff coverage is 89.87%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #54      +/-   ##
===========================================
- Coverage   100.00%   98.20%   -1.80%     
===========================================
  Files           14       18       +4     
  Lines          376      445      +69     
  Branches        93      111      +18     
===========================================
+ Hits           376      437      +61     
- Misses           0        8       +8     
Impacted Files Coverage Δ
src/locale/en.ts 100.00% <ø> (ø)
src/ValidatorContext.ts 75.00% <50.00%> (-25.00%) ⬇️
src/components/ValidatorProvider.tsx 92.64% <50.00%> (-7.36%) ⬇️
src/Validator.ts 97.95% <81.81%> (-2.05%) ⬇️
src/common/utils.ts 100.00% <100.00%> (ø)
src/rules/length.ts 100.00% <100.00%> (ø)
src/rules/maxLength.ts 100.00% <100.00%> (ø)
src/rules/minLength.ts 100.00% <100.00%> (ø)
src/rules/same.ts 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe9a5a1...882ffba. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant