fix: disable UDP connections on windows-rdp module #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
approved these changes
Jun 12, 2025
matifali
added
version:minor
matifali
requested review from
DevelopmentCats
and removed request for
bcpeinhardt
|
The next version should be 1.2.1. @DevelopmentCats, what's happening? |
If you are referring to the workflow it has not been merged yet. Want me to merge it and run the workflow? |
Signed-off-by: Spike Curtis <spike@coder.com>
spikecurtis
force-pushed
the
spike/windows-rdp-disable-udp
branch
from
cb9722c to
837773b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to
Fixes an issue where RDP doesn't function properly over Coder Connect, by disabling UDP and relying only on TCP. c.f. coder/internal#608 (comment) for a detailed description of the problem.
Type of Change
Module Information
Path:
registry/coder/modules/windows-rdpNew version:
v1.0.19Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun run fmt)Related Issues
coder/internal#608
Closes #