🤖 ci: add smoke test suite for npm package #625
Merged
+221
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add comprehensive smoke test suite that validates: - npm package installation from tarball - server startup with 'mux server' command - healthcheck endpoint returns valid JSON response - root endpoint is accessible The smoke test runs on merge to main and can also be run locally with: make smoke-test Test includes: - Proper cleanup of server processes and temp directories - Configurable timeouts for startup and healthcheck - Colored output for better visibility - Server logs uploaded as artifacts on failure _Generated with `mux`_
ibetitsmike
force-pushed
the
chat-mi1kmowy
branch
from
4cd9589 to
5f9740b
Compare
- Convert PACKAGE_TARBALL to absolute path before cd to avoid path resolution issues - Add pull_request trigger to smoke-test workflow so it runs on PRs Addresses Codex feedback about tarball path being relative after cd. _Generated with `mux`_
- Move smoke test from standalone workflow to publish-npm.yml - Run smoke test after build, before npm publish - Remove smoke-test.yml standalone workflow - Smoke test now acts as gate before publishing to npm This ensures packages are validated before publishing rather than after merge to main. _Generated with `mux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a comprehensive smoke test suite that validates the npm package can be installed and the server starts correctly.
What changed
scripts/smoke-test.sh: Bash script that installs the npm package from a tarball, starts the server, and validates the healthcheck endpoint.github/workflows/smoke-test.yml: CI workflow that runs smoke tests on merge to mainmake smoke-test: Local target for running smoke testsTesting
The smoke test validates:
node_modules/.bin/muxmux servercommand{"status": "ok"}The test includes proper cleanup (kills server, removes temp directories) and uploads server logs as artifacts on failure.
Running locally
This will:
Generated with
mux