🤖 Split file_edit_replace into two separate tools #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
https://github.com/coder/cmux/blob/9bdbc520d9807927f1f8b180690fbf92ce729406/src/utils/messages/toolOutputRedaction.ts#L13-L16
toolOutputRedaction.ts still imports FileEditReplaceToolResult and switches on file_edit_replace (lines 13‑14, 96). The type no longer exists after the rename and the new tools are file_edit_replace_string/file_edit_replace_lines, so this file will not compile and none of the replace-tool outputs will be redacted.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
ammar-agent
force-pushed
the
feature/file-edit-replace-lines
branch
4 times, most recently
from
ef564c6 to
c0ef42f
Compare
Collaborator
Author
|
Applied Codex suggestions: cleaned up file_edit_replace_lines definition and ensured create:true works before invoking shared helper. Re-ran tests locally. |
ammar-agent
force-pushed
the
feature/file-edit-replace-lines
branch
5 times, most recently
from
f1c9fda to
966e72c
Compare
ammar-agent
force-pushed
the
feature/file-edit-replace-lines
branch
from
ba9f0b8 to
0f1eb57
Compare
Consolidates file_edit_replace_string and file_edit_replace_lines into a single file_edit_replace tool using discriminated unions. Changes: - New unified tool with mode: 'string' | 'lines' discriminant - Updated type system with FileEditReplaceToolArgs union type - Simplified frontend with single tool rendering path - Updated all tool definitions, registries, and utilities - Removed legacy tool implementations and tests Benefits: - Simpler API (1 tool instead of 2) - Easier to extend with new modes - Reduced code duplication (~327 line net reduction) All tests passing (TypeScript, unit tests, tool policy tests). _Generated with `cmux`_
Prevents checking PR status when: - Working directory has uncommitted changes - Local branch doesn't have upstream configured - Local branch is out of sync with remote (ahead/behind/diverged) Provides clear error messages with suggested remediation steps. _Generated with `cmux`_
ammar-agent
force-pushed
the
feature/file-edit-replace-lines
branch
from
27c5f47 to
feca0e7
Compare
Instead of using a discriminated union (which AI providers don't support), create two separate tools that share implementation: - file_edit_replace_string: String-based text replacement - file_edit_replace_lines: Line range replacement - file_edit_replace_shared.ts: Shared helper functions Benefits: - Simple object schemas that AI providers accept - Code reuse through shared helpers - Clearer tool separation in registry - Type safety maintained throughout Updated: - Tool definitions with two separate simple schemas - Tool registry to register both tools - UI components to handle both tool names - Types to separate payload/result types - Tests to cover both tools independently
ammar-agent
changed the title
Update test to look for either file_edit_replace_string or file_edit_replace_lines instead of the old unified tool name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits file edit replace into two separate tools instead of using a discriminated union, as AI providers don't support complex union schemas.
Changes
file_edit_replace_string: String-based text replacementfile_edit_replace_lines: Line range replacementfile_edit_replace_shared.tsfor code reuseBenefits
Test Results
✅ TypeScript passing
✅ Unit tests passing (379 tests)
✅ Tool policy tests passing (20 tests)
✅ Lint + Format passing
Generated with
cmux