Skip to content

fix: run code-server as the appropriate user #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025
Merged

fix: run code-server as the appropriate user #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64d4c68
fix: run code-server as the appropriate user
DanielleMaywood Apr 8, 2025
7c18f31
chore: replace runuser with su
DanielleMaywood Apr 8, 2025
54bd19a
chore: add fedora to test suite
DanielleMaywood Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ jobs:
features:
- code-server
baseImage:
- fedora:latest
- debian:latest
- ubuntu:latest
- mcr.microsoft.com/devcontainers/base:ubuntu
Expand Down
2 changes: 1 addition & 1 deletion src/code-server/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ cat > /usr/local/bin/code-server-entrypoint \
#!/usr/bin/env bash
set -e

code-server --bind-addr "$HOST:$PORT" \$ARGS
su $_REMOTE_USER -c 'code-server --bind-addr "$HOST:$PORT" \$ARGS'
Copy link
Member

@mafredri mafredri Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity check: Is this remote user env always set?

Copy link
Collaborator Author

@DanielleMaywood DanielleMaywood Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the docs it should be https://containers.dev/implementors/features/#user-env-var

EOF

chmod +x /usr/local/bin/code-server-entrypoint
2 changes: 1 addition & 1 deletion test/code-server/code-server-extensions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ source dev-container-features-test-lib
# Feature-specific tests
check "code-server version" code-server --version
check "code-server running" pgrep -f 'code-server/lib/node.*/code-server'
check "code-server listening" sudo lsof -i "@0.0.0.0:8080"
check "code-server listening" lsof -i "@0.0.0.0:8080"

extensions=$(sudo code-server --list-extensions)

Expand Down
2 changes: 1 addition & 1 deletion test/code-server/code-server-install-version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ source dev-container-features-test-lib
# Feature-specific tests
check "code-server version" code-server --version
check "code-server running" pgrep -f 'code-server/lib/node.*/code-server'
check "code-server listening" sudo lsof -i "@0.0.0.0:8080"
check "code-server listening" lsof -i "@0.0.0.0:8080"

version=$(code-server --version)
check "code-server is correct version" grep '4.98.0\>' <<<"$version"
Expand Down
2 changes: 1 addition & 1 deletion test/code-server/code-server-modified-host.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ source dev-container-features-test-lib
# Feature-specific tests
check "code-server version" code-server --version
check "code-server running" pgrep -f 'code-server/lib/node.*/code-server'
check "code-server listening" sudo lsof -i "@0.0.0.0:8080"
check "code-server listening" lsof -i "@0.0.0.0:8080"

# Report results
reportResults
2 changes: 1 addition & 1 deletion test/code-server/code-server-modified-port.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ source dev-container-features-test-lib
# Feature-specific tests
check "code-server version" code-server --version
check "code-server running" pgrep -f 'code-server/lib/node.*/code-server'
check "code-server listening" sudo lsof -i "@127.0.0.1:1234"
check "code-server listening" lsof -i "@127.0.0.1:1234"

# Report results
reportResults
2 changes: 1 addition & 1 deletion test/code-server/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ source dev-container-features-test-lib
# Feature-specific tests
check "code-server version" code-server --version
check "code-server running" pgrep -f 'code-server/lib/node.*/code-server'
check "code-server listening" sudo lsof -i "@127.0.0.1:8080"
check "code-server listening" lsof -i "@127.0.0.1:8080"

# Report results
reportResults