Skip to content

change links so they don't throw a 404 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2021
Merged

change links so they don't throw a 404 #14

merged 2 commits into from
Mar 18, 2021

Conversation

rpxs
Copy link
Contributor

@rpxs rpxs commented Mar 17, 2021

Although there is probably a better way to do this, the current links throw 404 Not Found errors. I added a full URL to make it work.

@rpxs
change links so they don't throw a 404
643f8ab 
Although there is probably a better way to do this, the current links throw 404 Not Found errors. I added a full URL to make it work.
@ghost
Copy link

ghost commented Mar 18, 2021

../guides/PLATFORM.md should work and since guides is in the root dir, /guides/PLATFORM.md should work too

bpmct
bpmct approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I switched to relative links :)

@bpmct bpmct merged commit 862e4ad into coder:main Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpmct bpmct bpmct approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpxs @bpmct