chore: fix api param name #20172
Merged
chore: fix api param name #20172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Oct 6, 2025
| } | ||
| tags := p.JSONStringMap(qp, database.StringMap{}, "tags") | ||
| initiatorID := p.UUID(qp, uuid.Nil, "initiator_id") | ||
| initiatorID := p.UUID(qp, uuid.Nil, "initiator") |
Member
There was a problem hiding this comment.
Just checking; you're saying this will change in future work? If so, then 👍🏻
Contributor
Author
There was a problem hiding this comment.
The name of the parameter will remain "initiator". The valid domain for the param will expand from being a valid uuid to also being the name of any existing user, or the special value "me"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #20137, we added a new flag to
coder provisioner jobs list, namely--initiator.To make some follow-up worth it, I need to rename an API param used in the process before it becomes part of our released and tagged API.
Instead of only accepting UUIDs, we accept an arbitrary string.
We still validate it as a UUID now, but we will expand its validation to allow any string and then resolve that string the same way that we resolve the user parameter elsewhere in the API.