fix: improve JetBrains error message to mention Toolbox requirement #18294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blink-so[bot]](https://avatars.githubusercontent.com/in/1271127?s=60&v=4){kind=small}
When users try to open JetBrains IDEs (GoLand, IntelliJ, etc.) without having JetBrains Toolbox installed, they now receive a more helpful error message that specifically mentions the Toolbox requirement instead of the generic 'must be installed first' message. Fixes #17786 Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Apply Biome formatter requirements for consistent code style. Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
matifali
approved these changes
Jun 18, 2025
|
@kylecarbs I think this is a good enough workaround. |
Parkreiner
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
This looks fine to me for a stopgap. There's a tiny bug here, where if the user switches to a different tab before the external app opens, the browser will treat that as the tool not being installed, even though everything's perfectly fine. But that's a bug that was here previously – I can go ahead and make an issue for that
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users try to open JetBrains IDEs (GoLand, IntelliJ, etc.) without having JetBrains Toolbox installed, they now receive a more helpful error message that specifically mentions the Toolbox requirement instead of the generic "must be installed first" message.
Changes:
useAppLink.tsto detect JetBrains apps by their protocol (jetbrains-gateway:orjetbrains:)Testing:
Addresses #17786