Skip to content

chore: improve release workflow #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 31, 2024
Merged

chore: improve release workflow #60

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2c90507
chore: add prerelease flag to release.yaml and build.sh
matifali Jul 30, 2024
181afd4
replace deprecated actions
matifali Jul 30, 2024
13c6cdc
generate release notes
matifali Jul 30, 2024
20a8777
specify tag_name
matifali Jul 30, 2024
2125e4a
refactor to use `gh release create`
matifali Jul 31, 2024
ff82a7b
use asset name to match existing behaviour.
matifali Jul 31, 2024
7ade03c
makes sure we can run non-interactively in CI
matifali Jul 31, 2024
8dede44
cleanup
matifali Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
makes sure we can run non-interactively in CI
  • Loading branch information
@matifali
matifali committed Jul 31, 2024
commit 7ade03cfdcc64e448092f4cd9b89bd17ad5cda7d
17 changes: 9 additions & 8 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,18 @@ jobs:
set -euo pipefail
version=${{ steps.version.outputs.version }}

if gh release view $version; then
# check if release already exists and match the version
if [[ $(gh release view $version --json name -q '.name' | cat) == $version ]]; then
echo "Release $version already exists"
exit 0
fi

echo "Creating release $version"
# if version contains -rc, publish as a pre-release and don't set as latest
if [[ $version == *-rc* ]]; then
gh release create $version -t $version --generate-notes --prerelease --latest=false --verify-tag build/${version}.tgz#helm.tar.gz
else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can remove else case and outdent below block due to exit 0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also discovered that the gh release view is interactive and ensured it could run noninteractively.

echo "Creating release $version"
# if version contains -rc, publish as a pre-release and not latest
if [[ $version == *-rc* ]]; then
gh release create $version -t $version --generate-notes --prerelease --latest=false --verify-tag build/${version}.tgz#helm.tar.gz
else
gh release create $version -t $version --generate-notes --verify-tag build/${version}.tgz#helm.tar.gz
fi
gh release create $version -t $version --generate-notes --verify-tag build/${version}.tgz#helm.tar.gz
fi
env:
GITHUB_TOKEN: ${{ github.token }}