Skip to content

Use port from server.address() when printing the URL #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Use port from server.address() when printing the URL #780

merged 1 commit into from
Jun 17, 2019

Conversation

deansheather
Copy link
Member

Describe in detail the problem you had and how this PR fixes it

When using port 0 on code-server, instead of printing the randomly generated port it will print URLs with port 0. This fixes that by getting the port from the server when printing the URL.

There are also some logging consistency changes in there as well, as HTTP messages were being printed even if sockets were being used.

Is there an open issue you can link to?

Closes #779.

This allows the use of port 0, which is interpretted automatically to
mean "random port".

Additional logging consistency fixes.
@code-asher code-asher merged commit a9d1788 into coder:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect reporting in the terminal when --port 0 is used
2 participants