Skip to content

Set NODE_ENV and VERSION when building #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
code-asher merged 2 commits into from
May 20, 2019
+8 −2
Merged

Set NODE_ENV and VERSION when building #700

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf3e8a9
Set NODE_ENV and VERSION when building
code-asher May 20, 2019
95e685a
Log env vars
code-asher May 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Set NODE_ENV and VERSION when building 
Should fix the version flag not reporting correctly as well as enable
the service worker and prevent the 404 hmr requests again.
  • Loading branch information
@code-asher
code-asher committed May 20, 2019
commit cf3e8a95cbed72551472b01f2023b0777e4e1b6f
4 changes: 2 additions & 2 deletions scripts/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ function docker_build() {
docker cp ./. $containerID:/src
exec "cd /src && yarn"
exec "cd /src && npm rebuild"
exec "cd /src && yarn task build:server:binary"
exec "cd /src && NODE_ENV=production VERSION=$VERSION yarn task build:server:binary"
exec "cd /src && yarn task package $VERSION"
docker cp $containerID:/src/release/. ./release/
}

if [[ "$OSTYPE" == "darwin"* ]]; then
yarn task build:server:binary
NODE_ENV=production yarn task build:server:binary
else
if [[ "$TARGET" == "alpine" ]]; then
IMAGE="codercom/nbin-alpine"
Expand Down