Skip to content

Update Code to 1.93.0 #6984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
code-asher merged 6 commits into from
Sep 19, 2024
Merged

Update Code to 1.93.0 #6984

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
da3ba19
Update Code to 1.93.0
benz0li Sep 6, 2024
150942d
Update Code to 1.93.1
code-asher Sep 18, 2024
df09d5f
Attempt to fix Firefox e2e test with context menus
code-asher Sep 19, 2024
1676fd9
Wait for context menu
code-asher Sep 19, 2024
dea5e8d
Same fix for upload tests
code-asher Sep 19, 2024
a95331d
idk what is happening
code-asher Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Same fix for upload tests
  • Loading branch information
@code-asher
code-asher committed Sep 19, 2024
commit dea5e8d9a910963cdaa438440e4dfcca8493f6e7
2 changes: 0 additions & 2 deletions test/e2e/downloads.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ describe("Downloads (enabled)", ["--disable-workspace-trust"], {}, async () => {
// Action
await codeServerPage.openContextMenu("text=unique-file.txt")

await codeServerPage.page.waitForSelector(".context-view-block")
expect(await codeServerPage.page.isVisible("text=Download...")).toBe(true)
})

Expand Down Expand Up @@ -73,7 +72,6 @@ describe("Downloads (disabled)", ["--disable-workspace-trust", "--disable-file-d
// Action
await codeServerPage.openContextMenu("text=unique-file.txt")

await codeServerPage.page.waitForSelector(".context-view-block")
expect(await codeServerPage.page.isVisible("text=Download...")).toBe(false)
})

Expand Down
1 change: 1 addition & 0 deletions test/e2e/models/CodeServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,6 +566,7 @@ export class CodeServerPage {
const el = await this.page.waitForSelector(selector)
await el.click({ button: "left" })
await this.page.keyboard.press("Shift+F10")
await this.page.waitForSelector(".context-view-block")
}

/**
Expand Down
11 changes: 3 additions & 8 deletions test/e2e/uploads.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,8 @@ describe("Uploads (enabled)", ["--disable-workspace-trust"], {}, () => {
await fs.mkdir(tmpDirPath)

// Action
const fileInExplorer = await codeServerPage.page.waitForSelector('span:has-text("test-directory")')
await fileInExplorer.click({
button: "right",
})
await codeServerPage.openContextMenu('span:has-text("test-directory")')

expect(await codeServerPage.page.isVisible("text=Upload...")).toBe(true)
})

Expand All @@ -44,10 +42,7 @@ describe("Uploads (disabled)", ["--disable-workspace-trust", "--disable-file-upl
await fs.mkdir(tmpDirPath)

// Action
const fileInExplorer = await codeServerPage.page.waitForSelector('span:has-text("test-directory")')
await fileInExplorer.click({
button: "right",
})
await codeServerPage.openContextMenu('span:has-text("test-directory")')

expect(await codeServerPage.page.isVisible("text=Upload...")).toBe(false)
})
Expand Down