Skip to content

Catch getLayoutMap error #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Catch getLayoutMap error #3518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Catch getLayoutMap error 
This might be causing issues with the PWA showing a blank screen with
MacOS.
  • Loading branch information
@code-asher
code-asher committed Jun 1, 2021
commit a0ebfc666906503ec693d14d78f22b7093850b27
3 changes: 3 additions & 0 deletions lib/vscode/src/vs/workbench/services/keybinding/browser/keyboardLayoutService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,9 @@ export class BrowserKeyboardMapperFactoryBase {
// }

// return null;
}).catch(() => {
// NOTE@coder: It looks like the intention was to catch this error but
// a try/catch won't do it when using promises without `await`.
});
} catch {
// getLayoutMap can throw if invoked from a nested browsing context
Expand Down