Skip to content

fix(testing): reduce flakiness of terminal.test.ts and use 1 worker for e2e tests #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsjoeio merged 3 commits into from
Apr 30, 2021
Merged

fix(testing): reduce flakiness of terminal.test.ts and use 1 worker for e2e tests #3263

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c568300
chore: clean up yarn.lock
jsjoeio Apr 29, 2021
17f4c4c
fix(e2e): remove quotes from terminal type command
jsjoeio Apr 29, 2021
7309ea9
fix(e2e): use one worker to reduce flakiness
jsjoeio Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(e2e): remove quotes from terminal type command
  • Loading branch information
@jsjoeio
jsjoeio committed Apr 29, 2021
commit 17f4c4c330e3e72548d7d448d88e812146570bd9
2 changes: 1 addition & 1 deletion test/e2e/terminal.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ test.describe("Integrated Terminal", () => {
await codeServer.focusTerminal()

await page.waitForLoadState("load")
await page.keyboard.type(`echo '${testString}' > '${tmpFile}'`)
await page.keyboard.type(`echo ${testString} > ${tmpFile}`)
await page.keyboard.press("Enter")
// It may take a second to process
await page.waitForTimeout(1000)
Expand Down