adding in changes so that this will work with api 30 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some changes to allow the library to work when using a target sdk and compile sdk of 30 when running on Android 11. Before these changes you get an error because of an issue with okhttp which causes it to say that there is a min sdk of 21 but the target is 30, which is a known issue that was fixed with later versions. I left scribe at the older version because that was a much larger change, but updating asynchttpclient and logging-interceptor along with one small change to the TokenClient seemed to work even-though the dependencies the scribe okhttp are likely older (I'm guessing that they are segregated enough to not cause an issue).