This repository was archived by the owner on Dec 9, 2021. It is now read-only.
Create ActionUnion #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8rzz
reviewed
Nov 21, 2018
There was a problem hiding this comment.
I really like the union type, I'm sure that makes things a little easier to trace (even in webstorm). I am a little curious about why you moved the static methods back to within the switch statement? That will probably make testing these reducers just a little more difficult.
|
@n8rzz The static methods are private so you wouldn't test those. The only thing I was testing was to make sure the static methods in the reducer had the same action payload type as the action. With the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ccheney @n8rzz what do you think of this change?