This repository was archived by the owner on Dec 9, 2021. It is now read-only.
WIP:Webpack4 #22
Closed
WIP:Webpack4 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8rzz
reviewed
Nov 11, 2018
| "@babel/cli": "7.1.5", | ||
| "@babel/core": "7.1.5", | ||
| "@babel/plugin-proposal-class-properties": "7.1.0", | ||
| "@babel/plugin-proposal-object-rest-spread": "7.0.0", |
There was a problem hiding this comment.
do you still need this? even if babel needs it, isn't this covered by tsc?
There was a problem hiding this comment.
Not 100% but I am using Babel 7 to compile the ts now and not tsc
There was a problem hiding this comment.
Let's talk about that tomorrow. Why would you use an abstraction of ts to compile ts?
ccheney
suggested changes
Nov 12, 2018
| "version": "2.0.0", | ||
| "description": "Simple React Hot Loading example with Hapi Server-side rendering", | ||
| "engines": { | ||
| "node": ">=8.9.1" |
There was a problem hiding this comment.
Suggested change
| "node": ">=8.9.1" | |
| "node": ">=10.11.0" |
| } | ||
|
|
||
| public async startServer(): Promise<void> { | ||
| process.on('unhandledRejection', (err) => { |
There was a problem hiding this comment.
missing arg type?
Suggested change
| process.on('unhandledRejection', (err) => { | |
| process.on('unhandledRejection', (err: Error) => { |
|
|
||
| public async startServer(): Promise<void> { | ||
| process.on('unhandledRejection', (err) => { | ||
| console.log(err); |
There was a problem hiding this comment.
Suggested change
| console.log(err); | |
| console.error(err); |
| class ProviderUtility { | ||
|
|
||
| public static createProviderStore(initialState: any = {}, history: History = null, isServerSide: boolean = false): ISagaStore<IStore> { | ||
| public static createProviderStore(initialState: any = {}, history: History = null, isServerSide: boolean = false): ISagaStore { |
There was a problem hiding this comment.
Suggested change
| public static createProviderStore(initialState: any = {}, history: History = null, isServerSide: boolean = false): ISagaStore { | |
| public static createProviderStore(initialState: object = {}, history: History = null, isServerSide: boolean = false): ISagaStore { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.