Changes needed to make it compatible with cocos2d + JS bindings #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added "cc.associateWithNative": It does nothing, but needed for compatibility.
MenuItem: Changed the API a bit:
-> OLD: setTarget NEW: setCallback
-> ToggleMenuItem: initializes with a list of items. The callback is
set manually later (I have some doubts about this change, but it
is a bit better than the previous one)
Animation: OLD: createWithSpriteFrames NEW: create
Geometry: Started the new "rectIntersection" API... but I have not
finished it yet.
Updates the tests.
These changes are needed for the MoonWarrior coco2d+js bindings version.
TODO in cocos2d-html5:
- Finish rect and size API and merge them in one file
- Since touches events are not avaible in cocos2d-html5, it should be renamed
to "mouse events"
linshun
pushed a commit
that referenced
this pull request
Aug 11, 2012
Changes needed to make it compatible with cocos2d + JS bindings
Member
|
Thank you, Riq. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "cc.associateWithNative": It does nothing, but needed for compatibility.
MenuItem: Changed the API a bit:
-> OLD: setTarget NEW: setCallback
-> ToggleMenuItem: initializes with a list of items. The callback is
set manually later (I have some doubts about this change, but it
is a bit better than the previous one)
Animation: OLD: createWithSpriteFrames NEW: create
Geometry: Started the new "rectIntersection" API... but I have not
finished it yet.
Updates the tests.
These changes are needed for the MoonWarrior coco2d+js bindings version.
TODO in cocos2d-html5:
to "mouse events"