Fix document.body check #3327
Open
Fix document.body check #3327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| _determineRenderType(config); | ||
|
|
||
| document.body ? _load(config) : cc._addEventListener(window, 'load', _windowLoaded, false); |
Contributor
There was a problem hiding this comment.
It will wait for body to be loaded if it's not
Contributor
|
Can you provide a step by step instruction to reproduce the issue ? Normally, if document.body can't be accessed, it will wait until window.load, I believe body should be accessible by then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed that the current body check does not work properly all the times. We have replaced it with jQuery inspired check which will wait until document.body can be accessed.