Fix legacy Function.prototype.bind support #1623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current legacy support was throwing errors on some mobile devices (specifically an HTC Sense running Android 2.3.4). The value of args should be determined by the arguments passed to bind, not to the bound function. Several places throughout the codebase bind is used in this manner, so the legacy function should support it.
dingpinglv
added a commit
that referenced
this pull request
Mar 5, 2014
Fix legacy Function.prototype.bind support
Contributor
|
Thank you, erykwalder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current legacy support was throwing errors on some mobile devices (specifically an HTC Sense running Android 2.3.4).
The value of args should be determined by the arguments passed to bind, not to the bound function. Several places throughout the codebase bind is used in this manner, so the legacy function should support it.