fix bug: ProgressTime can't change color and opacity #1268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi Wupei, It works well to change color and opacity at our ProgressAction Test. Thanks for your noticing, I will refactor these codes soon. |
Contributor
Author
|
Hi, the ProgressTimer need call setPercentage(), then color and opacity is right. Call setColor and setOpacity directly can't work. |
Contributor
|
Yes, you are right. Did you test it on Canvas Mode? I think we should delete "updateColor" from _updateProgressForWebGL if we add "updateColor" to setColor and setOpacity. And then testing it on Canvas Mode. |
Contributor
Author
|
has fixed. And it is pass on Canvas Mode. |
Contributor
|
Thank you very much. Wupei |
dingpinglv
added a commit
that referenced
this pull request
Nov 27, 2013
fix bug: ProgressTime can't change color and opacity
dingpinglv
added a commit
to dingpinglv/cocos2d-html5
that referenced
this pull request
Dec 2, 2013
dingpinglv
added a commit
that referenced
this pull request
Dec 2, 2013
Fixed #1268: fixed a cc.ProgressTimer's bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.