change API name from cc.Control.removeTargetWithActionForControlEvent to _removeTargetWithActionForControlEvent #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to _removeTargetWithActionForControlEvent
Contributor
|
Great, you're right. Thank you, Ze. |
dingpinglv
added a commit
that referenced
this pull request
Sep 26, 2013
change API name from cc.Control.removeTargetWithActionForControlEvent to _removeTargetWithActionForControlEvent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change API name from cc.Control.removeTargetWithActionForControlEvent to _removeTargetWithActionForControlEvent
1、In my opinion , API name should be symmetrical , such as _addTarget and removeTarget
2、removeTargetWithActionForControlEvent is a protected function in cocos2d-x , so it should be add "" prefix in cocos2d-html5 such as _addTargetWithActionForControlEvent