fix(clerk-react): Export HOC-related types to support older React pat… #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anagstef
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
💡 Maybe we want to add some tests for exporting stuff or is it too much? (cc @nikosdouvlis)
gkats
approved these changes
Jan 11, 2023
SokratisVidros
approved these changes
Jan 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…terns
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/backend-core@clerk/clerk-sdk-node@clerk/edge@clerk/sharedbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.Our docs: https://clerk.dev/docs/reference/clerk-react/useuser state that withUser can be used with the WithUserProp type, which we currently do not export.
This PR correctly exports the
WithUserPropand other HOC-related helper types from all related packages (react, nextjs etc)COR-58