refactor(clerk-js): Introduce <Drawer.Confirmation /> component
#5376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: c362b57 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/clerk-js/src/ui/components/PricingTable/PlanDetailDrawer.tsx
Outdated
Show resolved
Hide resolved
panteliselef
approved these changes
Mar 17, 2025
packages/clerk-js/src/ui/components/PricingTable/PlanDetailDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/PricingTable/PlanDetailDrawer.tsx
Outdated
Show resolved
Hide resolved
| const Confirmation = React.forwardRef<HTMLDivElement, ConfirmationProps>(({ open, onOpenChange, children }, ref) => { | ||
| const prefersReducedMotion = usePrefersReducedMotion(); | ||
| const { animations: layoutAnimations } = useAppearance().parsedLayout; | ||
| const isMotionSafe = !prefersReducedMotion && layoutAnimations === true; |
There was a problem hiding this comment.
Does it make sense to simply return this from usePrefersReducedMotion ?
There was a problem hiding this comment.
I tried introducing a useMotionSafe hook that handled both of these hooks but ran into a circular import issue. Can revisit in the future again.
alexcarpenter
deleted the
alexcarpenter/com-148-refactor-cancelfooter-component-within-plandetaildrawer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce
<Drawer.Confirmation />component to be used within Commerce cancel subscription flow.Screen.Recording.2025-03-17.at.3.42.24.PM.mov
Resolves COM-148
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change